Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub action build publish error and publish Buefy v0.9.27 #3959

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

wesdevpro
Copy link
Member

@wesdevpro wesdevpro commented Jan 3, 2024

Fixes #3957

Proposed Changes

  • Bump version to 0.9.26.
  • Update the publish Github action packages that publish Buefy.
  • Add build step to the publish Github action.

* fix: dist was not built before publish to npm

- Fixes the issue that the `dist` folder was not built before publishing
  to npm. `package.json` used to include `prepare` script that runs
  `build:lib` script and `npm ci` built the `dist` folder. I removed
  `prepare` script in the commit ccbdc8e
  because `npm install` took very long. So we have to run `build:lib`
  before `publish` now.

* chore(gha): update npm_deploy dependencies

- Updates dependencies of `npm_deploy` GitHub Actions workflow:
    - Bump Node to v18.x
    - Bump actions/checkout to v4
    - Bump actions/setup-node to v4
- We had a problem with GitHub Actions workflow for npm publish.
@wesdevpro wesdevpro self-assigned this Jan 3, 2024
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for buefy-org ready!

Name Link
🔨 Latest commit 36c97d8
🔍 Latest deploy log https://app.netlify.com/sites/buefy-org/deploys/65957a0925a3210008a530c3
😎 Deploy Preview https://deploy-preview-3959--buefy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kikuomax kikuomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be fine this time!

@kikuomax kikuomax merged commit 9a36355 into master Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants