Tooltip Glitchy (#3753) #3914
Merged
Tooltip Glitchy (#3753) #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the issue that `Tooltip` is shown at a place slightly shifted from the expected one when `appendToBody` is `true`, and `position` is "is-top" or "is-bottom". Specifies the absolute position of the anchor element (`tooltipEl`) instead of the `wrapper` element. See buefy#3753 (comment)
- Fixes the issue that `Tooltip` did not respond to resizing when it was
appended to body. Observes changes in the sizes of windown and the
immediate parent element. See the comment:
- buefy#3753 (comment)
- Fixes the issue that a Tooltip was slightly dislodged when a Modal was
just opened if the Tooltip was in the Modal and appended to body. This
should have been caused by the CSS transition involving changes in the
Modal size. Updates the position after the CSS transition of the
closest `.animation-content` if such an element exists. See the
comment:
- buefy#3753 (comment)
✅ Deploy Preview for buefy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wesdevpro
approved these changes
Dec 8, 2023
64 tasks
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Jan 10, 2024
* fix(lib): tooltip layout (appendToBody) - Fixes the issue that `Tooltip` is shown at a place slightly shifted from the expected one when `appendToBody` is `true`, and `position` is "is-top" or "is-bottom". Updates the absolute position of the anchor element (`tooltipEl`) instead of the `wrapper` element. See buefy#3753 (comment) * fix(lib): Tooltip did not respond to resize - Fixes the issue that `Tooltip` did not respond to resizing when it was appended to body. Observes changes in the sizes of windown and the immediate parent element. See the comment: - buefy#3753 (comment) * fix(lib): Tooltip was dislodge when Modal opened - Fixes the issue that a Tooltip was slightly dislodged when a Modal was just opened if the Tooltip was in the Modal and appended to body. This should have been caused by the CSS transition involving changes in the Modal size. Updates the position after the CSS transition of the closest `.animation-content` if such an element exists. See the comment: - buefy#3753 (comment) Also fixes buefy#3065
This was referenced Jan 24, 2024
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Feb 11, 2024
* fix(lib): tooltip layout (appendToBody) - Fixes the issue that `Tooltip` is shown at a place slightly shifted from the expected one when `appendToBody` is `true`, and `position` is "is-top" or "is-bottom". Updates the absolute position of the anchor element (`tooltipEl`) instead of the `wrapper` element. See buefy#3753 (comment) * fix(lib): Tooltip did not respond to resize - Fixes the issue that `Tooltip` did not respond to resizing when it was appended to body. Observes changes in the sizes of windown and the immediate parent element. See the comment: - buefy#3753 (comment) * fix(lib): Tooltip was dislodge when Modal opened - Fixes the issue that a Tooltip was slightly dislodged when a Modal was just opened if the Tooltip was in the Modal and appended to body. This should have been caused by the CSS transition involving changes in the Modal size. Updates the position after the CSS transition of the closest `.animation-content` if such an element exists. See the comment: - buefy#3753 (comment) Also fixes buefy#3065
kikuomax
added a commit
to ntohq/buefy-next
that referenced
this pull request
Feb 12, 2024
* fix(lib): tooltip layout (appendToBody) - Fixes the issue that `Tooltip` is shown at a place slightly shifted from the expected one when `appendToBody` is `true`, and `position` is "is-top" or "is-bottom". Updates the absolute position of the anchor element (`tooltipEl`) instead of the `wrapper` element. See buefy#3753 (comment) * fix(lib): Tooltip did not respond to resize - Fixes the issue that `Tooltip` did not respond to resizing when it was appended to body. Observes changes in the sizes of windown and the immediate parent element. See the comment: - buefy#3753 (comment) * fix(lib): Tooltip was dislodge when Modal opened - Fixes the issue that a Tooltip was slightly dislodged when a Modal was just opened if the Tooltip was in the Modal and appended to body. This should have been caused by the CSS transition involving changes in the Modal size. Updates the position after the CSS transition of the closest `.animation-content` if such an element exists. See the comment: - buefy#3753 (comment) Also fixes buefy#3065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
These commits might not be sufficient to fix the problem in #3753, because there was no reproduction code, and I was not able to watch the attached video. However, they fix as many problems as I could find on my machine (macOS/Safari, Chrome).
Tooltips appended to body by specifying the absolute position of the anchor element (tooltipEl) instead of thewrapperelementTooltips in response to resizing window and the parent elementTooltips after theModalCSS transition completes ifTooltips are in aModalTooltips were slightly dislodged just after theModalwas opened