Draft: Use the color-parser props for colorPicker value #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About Color class you can add it in the index.js so the user can import using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR to open conversation about the ColorPicker component:
When setting the
color-parserprop in a ColorPicker, it's used only at the component definition (mounting). It feels like a bug, but I don't know if this is intentionnal.Also I would like to point out that throwing error on color parsing is kinda annoying. This force the user to deal with uncaught exception bubbling.
One last thing, the
Colorclass is not exported by Buefy. User needs toimport 'buefy/src/utils/color.js?module'to access it, which is not trivial to guess.