Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainhash: Implement a new chainhash package. #730

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Aug 8, 2016

This PR requires #728.

This is a backport of the chainhash package made in Decred along with a few additional things cleaned up, finished test coverage, and rewording of some documentation to make it more generic.

In particular, the new package provides the definition of the hash type and associated hashing functions which will allow the rest of the code to be agnostic to the specific hash algorithm.

This only implements the package and does not change any of the code base over to use it.

@jrick
Copy link
Member

jrick commented Aug 8, 2016

ok

This is a backport of the chainhash package made in Decred along with a
few additional things cleaned up, finished test coverage, and rewording
of some documentation to make it more generic.

In particular, the new package provides the definition of the hash type
and associated hashing functions which will allow the rest of the code to be
agnostic to the specific hash algorithm.

This only implements the package and does not change any of the code
base over to use it.
@jcvernaleo
Copy link
Member

OK

@dajohi
Copy link
Member

dajohi commented Aug 8, 2016

ok

@davecgh davecgh merged commit 711f334 into btcsuite:master Aug 8, 2016
@davecgh davecgh deleted the chainhashpkg branch August 8, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants