rpcclient: update error str to match both versions #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the error str to match the same error returned from `btcd` for both pre-0.24.2 and post-0.24.2.
Pull Request Test Coverage Report for Build 9660242373Details
💛 - Coveralls |
guggero
approved these changes
Jun 25, 2024
hieblmi
reviewed
Jul 2, 2024
| @@ -411,7 +411,10 @@ var BtcdErrMap = map[string]error{ | |||
| "transaction already exists in blockchain": ErrTxAlreadyConfirmed, | |||
|
|
|||
| // A transaction in the mempool. | |||
| "already have transaction in mempool": ErrTxAlreadyInMempool, | |||
| // | |||
| // NOTE: For btcd v0.24.2 and beyond, the error message is "already | |||
There was a problem hiding this comment.
shouldn't this be For btcd versions prior to v0.24.2, the error message is "already have transaction in mempool"?
There was a problem hiding this comment.
In v0.24 the error msg is already have transaction, in 0.24.2 the error msg is changed to already have transaction in mempool, otherwise the match won't fail since already have transaction is a subset of already have transaction in mempool.
There was a problem hiding this comment.
Thanks now it makes sense. I got confused cause the new code references the old message.
btcfind
pushed a commit
to btcfind/btcd
that referenced
this pull request
Sep 26, 2024
This commit updates the error str to match the same error returned from `btcd` for both pre-0.24.2 and post-0.24.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the error str to match the same error returned from
btcdfor both pre-0.24.2 and post-0.24.2.