Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signrawtransactionwithwallet command interface #1642

Merged

Conversation

henryperson
Copy link
Contributor

Re-creating #1561 after I deleted it. I probably didn't need to delete it but even with running the requested git commands my branch diff vs this repo's master still had 8 or 9 commits so I made the thing from scratch off upstream/master, cherry picked and squashed the relevant commits.

Adds interface for issuing a signrawtransactionwithwallet command.
Note that this does not add functionality for the btcd rpc server
itself, it simply assumes that the RPC client has this ability and gives
an API for interacting with the RPC client.

rpc: add signrawtransactionwithwallet interface
@henryperson
Copy link
Contributor Author

Tagging @onyb to make sure you see this

@coveralls
Copy link

coveralls commented Sep 28, 2020

Pull Request Test Coverage Report for Build 276967942

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 8 of 73 (10.96%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 53.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/rawtransactions.go 0 65 0.0%
Files with Coverage Reduction New Missed Lines %
database/ffldb/blockio.go 4 92.62%
Totals Coverage Status
Change from base Build 272743387: -0.09%
Covered Lines: 20746
Relevant Lines: 38781

💛 - Coveralls

Copy link
Contributor

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@onyb onyb added the rpc label Sep 28, 2020
@onyb onyb added this to the 0.22.0 milestone Sep 28, 2020
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants