Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcctl: add regtest mode to btcctl #1556

Merged
merged 1 commit into from
May 13, 2020

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Apr 2, 2020

This adds regtest support to btcctl and fixes #1456. btcctl will respond with "cannot use -wallet with -regtest, btcwallet not yet compatible with regtest" because regtest is not yet supported in btcwallet.

Copy link
Contributor

@torkelrogstad torkelrogstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcvernaleo
Copy link
Member

Just waiting on travis and then this can go in.

@jakesylvestre
Copy link
Collaborator

image
Less than helpful so far

@Rjected Rjected force-pushed the add_regtest_to_btcctl branch 2 times, most recently from c9c2314 to ee79ce4 Compare April 14, 2020 11:13
@Rjected Rjected force-pushed the add_regtest_to_btcctl branch from ee79ce4 to d7a991f Compare April 14, 2020 11:43
@Rjected
Copy link
Contributor Author

Rjected commented Apr 30, 2020

@jcvernaleo I force-pushed to get travis to run, it's fixed now, just fyi

@Rjected Rjected mentioned this pull request May 12, 2020
@jcvernaleo
Copy link
Member

Oops, totally forgot to merge this one. Sorry about that.

@jcvernaleo jcvernaleo merged commit b470eee into btcsuite:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add regtest flag to btcctl
4 participants