Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize load time of StoreRoles related pages/routes #6245

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

NicolasDorier
Copy link
Member

@NicolasDorier NicolasDorier commented Sep 25, 2024

The GetStoreRole was loading all the users of the DB on big instances just because we wanted the IsUsed boolean...
On big instances the Roles page were taking minutes to open. (or even timeout crash)

@NicolasDorier NicolasDorier merged commit 056f850 into btcpayserver:master Sep 25, 2024
2 of 4 checks passed
@NicolasDorier NicolasDorier deleted the rolesrefactor branch September 25, 2024 14:10
@dennisreimann
Copy link
Member

This should then consequently also remove the In Use display from the UI, right?

@NicolasDorier
Copy link
Member Author

It shouldn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants