-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greenfield: Add image upload for app items #6226
Greenfield: Add image upload for app items #6226
Conversation
YES! I was going to make an issue for this, and you already have a PR 💥💥 |
e63b263
to
44457d2
Compare
A user who wants to update will need to upload the file via the API to the file service, then reference it through an UnresolvedUri. |
Hmm, but there are dedicated upload actions for the store logo as well as the user profile picture. |
@dennisreimann this really sucks, we don't want to add a separate routes everytimes we want to upload a logo. Let me think about it. |
We could do it via the GreenfieldFilesController, but we'd have to relax the permission requirement. When I implemented it, I matched the original UI-based file action policies, which make it available to admins only. |
BTCPayServer/Controllers/GreenField/GreenfieldAppsController.cs
Outdated
Show resolved
Hide resolved
44457d2
to
094e80a
Compare
Are you uploading the files base64 encoded or using HTTP form encoding? From an API POV, the base64 way may be more convenient? |
HTTP form, that's also how we implemented the other upload endpoints. |
72ecb6e
to
9024072
Compare
b97b5c7
to
29cbe12
Compare
Upload endpoints for app item images. Follow-up to btcpayserver#6075. Tested to work with the app item editor. Uses UploadImage consistently in API and UI.
29cbe12
to
457e3dc
Compare
Upload endpoints for app item images. Follow-up to #6075.
Tested to work with the app item editor.