Final detection layer #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 75.17% 79.24% +4.06%
==========================================
Files 25 26 +1
Lines 721 766 +45
==========================================
+ Hits 542 607 +65
+ Misses 179 159 -20
Continue to review full report at Codecov.
|
0x00b1
reviewed
Aug 25, 2017
keras_rcnn/layers/detection.py
Outdated
| return [(1, None, 4), (1, None, 3)] | ||
|
|
||
| def compute_mask(self, inputs, mask=None): | ||
| return 2 * [None] |
keras_rcnn/layers/detection.py
Outdated
|
|
||
|
|
||
| def compute_output_shape(self, input_shape): | ||
| return [(1, None, 4), (1, None, 3)] |
There was a problem hiding this comment.
1 should be None (or input_shape[0])
keras_rcnn/layers/detection.py
Outdated
|
|
||
| return [keras.backend.expand_dims(pred_boxes, 0), keras.backend.expand_dims(pred_scores, 0)] | ||
|
|
||
|
|
0x00b1
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the model's output isn't exactly the boxes you'd be interested in, so this layer should output those boxes/labels.
I'm not sure what a good name would be for it though.