Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tests #90

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Fix Tests #90

merged 3 commits into from
Aug 21, 2017

Conversation

jhung0
Copy link
Contributor

@jhung0 jhung0 commented Aug 19, 2017 •
edited
Loading

#75

@codecov-io
Copy link

Codecov Report

Merging #90 into master will increase coverage by 6.53%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   68.03%   74.57%   +6.53%     
==========================================
  Files          25       25              
  Lines         704      704              
==========================================
+ Hits          479      525      +46     
+ Misses        225      179      -46
Impacted Files Coverage Δ
keras_rcnn/backend/common.py 92.22% <0%> (ø) ⬆️
keras_rcnn/backend/tensorflow_backend.py 97.77% <0%> (+2.22%) ⬆️
...ras_rcnn/layers/object_detection/_anchor_target.py 99.13% <0%> (+9.56%) ⬆️
keras_rcnn/layers/losses/_rpn.py 96.15% <0%> (+65.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18fada...b5f5765. Read the comment docs.

@0x00b1
Copy link
Contributor

0x00b1 commented Aug 21, 2017

Woo!

0x00b1
0x00b1 approved these changes Aug 21, 2017
View reviewed changes
keras_rcnn/backend/common.py
@@ -177,7 +177,7 @@ def overlap(a, b):


def smooth_l1_loss(y_true, y_pred):
delta = 0.5
delta = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhung0 IIRC, the Faster RCNN paper uses 0.5.

@0x00b1 0x00b1 merged commit 1e48b1d into broadinstitute:master Aug 21, 2017
@jhung0 jhung0 deleted the tests branch January 24, 2018 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x00b1 0x00b1 0x00b1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhung0 @codecov-io @0x00b1