Fixed debug log severity for read threading messages. #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesemery
reviewed
Jul 17, 2023
| @@ -396,7 +396,7 @@ List<Haplotype> findBestPaths(final Collection<T> graphs, final Map<T, AssemblyR | |||
| resultSet.add(h); | |||
| } | |||
|
|
|||
| logger.log(debug ? Level.INFO : Level.OFF, () -> "Adding haplotype " + h.getCigar() + " from graph with kmer " + assemblyResult.getKmerSize()); | |||
| logger.log(debug ? Level.INFO : Level.TRACE, () -> "Adding haplotype " + h.getCigar() + " from graph with kmer " + assemblyResult.getKmerSize()); | |||
There was a problem hiding this comment.
So the issue is that calling logger.log(Level.OFF, message) will print that message in every case if you turn the logger off? If thats true I actually want you to revert these to the way they were before they were recently refactored (which i reviewed and didn’t catch here)… replace them with the previous statements
if(debug) {
logger.info( "Not using kmer size of " + kmerSize + " in read threading assembler because reference contains non-unique kmers");
}
|
Can this be fixed before an upcoming release? |
|
@jamesemery Yeah - back to you with updates. |
jamesemery
approved these changes
Aug 16, 2023
rickymagner
pushed a commit
that referenced
this pull request
Nov 28, 2023
* Fixed debug log severity for read threading messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.