Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up the CWL conformance test timeout BT-272 #6336

Merged
merged 1 commit into from
May 6, 2021

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented May 6, 2021

No description provided.

@kshakir
Copy link
Contributor Author

kshakir commented May 6, 2021

Update is based on this analysis:

workflow_duration_by_status

See BT-272 for the R script.

Edit: Filtered out the workflows that run the individual tests as workflows. Those wrapper workflows were the ones failing (as expected) after ~90 minutes.

@kshakir kshakir requested review from breilly2 and mcovarr May 6, 2021 05:50
Copy link
Contributor

@breilly2 breilly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, and ⭐ for the analysis! TOL: it looks like maybe 1800 would be sufficient given the data, but I don't mind having a little extra headroom.

@kshakir kshakir merged commit 187c49d into develop May 6, 2021
@kshakir kshakir deleted the ks_up_conformance_timeout branch May 6, 2021 18:55
@geoffjentry
Copy link
Contributor

@kshakir I think Hadley Wickham would approve of your evidence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants