Reference Disk Opt-in: Cromwell work [CROM-6663] #6048
Conversation
mcovarr
force-pushed
the
mlc_reference_disk_workflow_option
branch
from
228c2ab to
3ba676c
Compare
| @@ -0,0 +1,12 @@ | |||
| name: invalid_use_reference_disks_specification | |||
There was a problem hiding this comment.
Suggestion: rename file to invalid_use_reference_disks_specification.test
There was a problem hiding this comment.
oops yes, that should be its name
| (referenceInputsToMountedPaths, referenceFilesLocalizationScript) | ||
| } | ||
|
|
||
| val (maybeReferenceInputsToMountedPaths, maybeReferenceFilesLocalizationScript) = if (useReferenceDisks) { |
There was a problem hiding this comment.
With a properly configured backend, this looks like it used to use reference disks by default. Now, it looks like the default is to not use reference disks unless the workflow option is provided and true. How worried should we be about this change in default behavior?
There was a problem hiding this comment.
discussed in standup, this feature is not currently enabled in Terra prod since it is not set up in config
| @@ -0,0 +1,15 @@ | |||
| name: reference_disk_test_false_option | |||
There was a problem hiding this comment.
This test took over 21 minutes when I ran it! (The others were much quicker.)
mcovarr
force-pushed
the
mlc_reference_disk_workflow_option
branch
from
3ba676c to
621ea1c
Compare
No description provided.