Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-call-cached tasks [BA-6282] #5426

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

cjllanwarne
Copy link
Contributor

@cjllanwarne cjllanwarne commented Feb 22, 2020

Adds a meta attribute that allows people to mark tasks as non-call-cacheable.

Note: Marking as a community contribution since this was an out-of-hours project.

@cjllanwarne cjllanwarne added Priority: Low Community Contribution A pull request from the Cromwell open-source community labels Feb 22, 2020
@cjllanwarne cjllanwarne changed the title Allow non-call-cached tasks Allow non-call-cached tasks [BA-6282] Feb 24, 2020
Copy link
Contributor

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOL is it worth demonstrating this could be turned on by default_runtime_attributes and overridden in the task?


task volatile_task {
meta {
description: "Do something stochastic. We don't want this to call cache!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOL missed rhyming opportunity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to have a call cache trick?

@cjllanwarne
Copy link
Contributor Author

@mcovarr it's not a runtime attribute so it currently wouldn't be settable anywhere except in the task's meta section.

Now, "should this be a runtime attribute" might be a valid question...

Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cjllanwarne cjllanwarne merged commit 6d2875d into develop Feb 25, 2020
@cjllanwarne cjllanwarne deleted the cjl_volatile_tasks branch February 25, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A pull request from the Cromwell open-source community Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants