Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitesize doc: Evaluating WDL expressions in WOM [BA-6198] #5398

Merged
merged 4 commits into from
Jan 30, 2020

Conversation

cjllanwarne
Copy link
Contributor

No description provided.

@cjllanwarne cjllanwarne changed the title Bitesize doc: Evaluating WDL expressions in WOM Bitesize doc: Evaluating WDL expressions in WOM [BA-6198] Jan 29, 2020

#### Expressions in WOM

Expressions in the WOM model all expose the following methods:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATM machine

* Reference resolution between WDLOM elements occurs during the linking phase.
* WDLOM `ExpressionElement`s are wrapped into `WdlomWomExpression`s during the graph building phase.

It is during the graph construction phase that static expression elements are mixed together with evaluation functions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is during the graph construction phase that static expression elements are mixed together with evaluation functions
During the graph construction phase static expression elements are mixed together with evaluation functions

@cjllanwarne cjllanwarne force-pushed the cjl_bitesize_evaluating_expressions branch from 669f4ec to f79c810 Compare January 30, 2020 17:57

#### Where evaluation functions are coded

The four evaluators types described in "Expressions in WOM" are coded in four package objects for each version. They live in:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The four evaluators types described in "Expressions in WOM" are coded in four package objects for each version. They live in:
The four evaluator types described in "Expressions in WOM" are coded in four package objects for each version. They live in:

@cjllanwarne cjllanwarne merged commit 39bb46a into develop Jan 30, 2020
@cjllanwarne cjllanwarne deleted the cjl_bitesize_evaluating_expressions branch January 30, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants