-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitesize doc: Evaluating WDL expressions in WOM [BA-6198] #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjllanwarne
changed the title
Bitesize doc: Evaluating WDL expressions in WOM
Bitesize doc: Evaluating WDL expressions in WOM [BA-6198]
Jan 29, 2020
aednichols
approved these changes
Jan 29, 2020
|
||
#### Expressions in WOM | ||
|
||
Expressions in the WOM model all expose the following methods: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATM machine
* Reference resolution between WDLOM elements occurs during the linking phase. | ||
* WDLOM `ExpressionElement`s are wrapped into `WdlomWomExpression`s during the graph building phase. | ||
|
||
It is during the graph construction phase that static expression elements are mixed together with evaluation functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
It is during the graph construction phase that static expression elements are mixed together with evaluation functions | |
During the graph construction phase static expression elements are mixed together with evaluation functions |
cjllanwarne
force-pushed
the
cjl_bitesize_evaluating_expressions
branch
from
January 30, 2020 17:57
669f4ec
to
f79c810
Compare
mcovarr
approved these changes
Jan 30, 2020
|
||
#### Where evaluation functions are coded | ||
|
||
The four evaluators types described in "Expressions in WOM" are coded in four package objects for each version. They live in: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The four evaluators types described in "Expressions in WOM" are coded in four package objects for each version. They live in: | |
The four evaluator types described in "Expressions in WOM" are coded in four package objects for each version. They live in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.