Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suppressed arguments with duplicate names + light refactor for maintainability #174

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Oct 11, 2024

Fixes #170

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (2df6aa1) to head (ae3ce98).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          25       25           
  Lines        2077     2079    +2     
=======================================
+ Hits         2071     2073    +2     
  Misses          6        6           
Flag Coverage Δ
unittests 99.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit 4cbf663 into main Oct 11, 2024
15 checks passed
@brentyi brentyi deleted the brent/suppressed_improvement branch October 11, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature?: Allow conflicting option strings/names for supressed arguments
1 participant