This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
block chrome://brave and brave:// loads in tabs #15261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: will DM to QA
diracdeltas
force-pushed
the
fix/chrome-brave
branch
from
cf08cc9 to
f68ffa3
Compare
bridiver
reviewed
Oct 4, 2018
app/filtering.js
Outdated
| @@ -118,6 +118,11 @@ if (process.env.NODE_ENV === 'development') { | |||
| function registerForBeforeRequest (session, partition) { | |||
| const isPrivate = module.exports.isPrivate(partition) | |||
| session.webRequest.onBeforeRequest((details, muonCb) => { | |||
| if (details.url && details.url.includes('chrome://brave/') && | |||
| details.tabId !== -1) { | |||
There was a problem hiding this comment.
tabs can be -1 here for renderer initiated new tabs/windows that start to load before they are assigned to a window
bridiver
reviewed
Oct 4, 2018
app/filtering.js
Outdated
| @@ -118,6 +118,11 @@ if (process.env.NODE_ENV === 'development') { | |||
| function registerForBeforeRequest (session, partition) { | |||
| const isPrivate = module.exports.isPrivate(partition) | |||
| session.webRequest.onBeforeRequest((details, muonCb) => { | |||
| if (details.url && details.url.includes('chrome://brave/') && | |||
There was a problem hiding this comment.
we should also check against brave://
use startsWith instead of includes because these are valid strings in a URL path
|
added brave:// |
to app/extensions/brave/*
diracdeltas
changed the title
bridiver
approved these changes
Oct 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15237
Test Plan:
will DM to QA
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests