This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix topsites never returning after exclusion #12806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Jan 23, 2018
app/browser/api/topSites.js
Outdated
| @@ -85,6 +89,7 @@ const getTopSiteData = () => { | |||
| let sites = historyState.getSites(state) | |||
| .filter((site, key) => !isSourceAboutUrl(site.get('location')) && | |||
| !isPinned(state, key) && | |||
| !isIgnored(state, site.get('key')) && | |||
There was a problem hiding this comment.
can we use just key here same as for isPinned?
cezaraugusto
force-pushed
the
topsites/excluded/10411
branch
from
c04a787 to
341fdb3
Compare
LaurenWags
reviewed
Jan 23, 2018
There was a problem hiding this comment.
Assuming a clean profile, if I use the STR from the Test Plan Description I don't get a 6th tile.
If I follow the STR from #10411 (comment) I do get a 6th tile.
bsclifton
previously approved these changes
Jan 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #12806 +/- ##
==========================================
+ Coverage 56.09% 56.11% +0.01%
==========================================
Files 279 279
Lines 27309 27314 +5
Branches 4444 4445 +1
==========================================
+ Hits 15319 15326 +7
+ Misses 11990 11988 -2
|
cezaraugusto
force-pushed
the
topsites/excluded/10411
branch
from
341fdb3 to
c77674e
Compare
LaurenWags
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
both scenarios tried in #12806 (review) work as expected :)
bsclifton
added a commit
that referenced
this pull request
Jan 23, 2018
fix topsites never returning after exclusion
bsclifton
added a commit
that referenced
this pull request
Jan 23, 2018
fix topsites never returning after exclusion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @LaurenWags
fix #10411
STR:
Please note that we debounce all newtab page data so the sixth tile will be shown only after a new site visit, even if you have other sites on the list.