Adds cardholder_name attribute reader for Apple Pay Card #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollabaq86
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
👋 @AxelTheGerman thanks for the PR! This looks good to me, I don't have an ETA on when this will get released, but it is on our radar.
|
for internal tracking, ticket 1717 |
|
@AxelTheGerman Thank you for submitting this PR! Changes will be added in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #227 which describes the issue of
cardholder_nameinstance variable being assigned but not exposed viaattr_readerunlike the regularCreditCardobject.Checklist
#unreleasedsection, add that and your changelog entry to the top of the changelog)rake test:unit)