Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpng warning when compiling with gradle #16

Closed
designatednerd opened this issue Dec 30, 2014 · 12 comments
Closed

libpng warning when compiling with gradle #16

designatednerd opened this issue Dec 30, 2014 · 12 comments

Comments

@designatednerd
Copy link

Every time I build using Gradle on Android Studio, I get warnings of this type for pretty much every drawable resource in your library:

[path to project]/com.braintreepayments.api/braintree/1.2.7/res/drawable-mdpi-v4/bt_loading.png: libpng warning: iCCP: Not recognizing known sRGB profile that has been edited

Is there some kind of setting I should be looking at to ignore this on my end? Or is this something you guys can fix on your end?

@gbramwell
Copy link

What version of the build tools are you using? We haven't seen the issue, but similar problems have been reported with 21.0.0 and 21.0.1 on other projects.

@designatednerd
Copy link
Author

From my app's build.gradle file in the android closure:

buildToolsVersion "21.1.2"

@gbramwell
Copy link

What OS and Java version are you using? Would you be willing to share a stacktrace?

If possible, I'd be curious to see if compilation using build tools circa version 19 works. In the meantime, we'll see if we can reproduce the issue.

@designatednerd
Copy link
Author

Using Yosemite 10.10.1 (14B25), my JDK is jdk1.7.0_51.jdk. And unfortunately I need to use v21+ of the Build Tools to use RecyclerView in my app, so I can't just drop down the build tools.

The app builds - I'm just getting a ton of log barf in the process.

@lkorth
Copy link
Member

lkorth commented Dec 31, 2014

This is just an issue with the version of libpng aapt uses (https://code.google.com/p/android/issues/detail?id=77704).

These are just warnings because the newer libpng we built against is stricter about the color profile. We will fix this in an upcoming release, but this shouldn't be an issue.

Future updates of the build tools should fix this, for now it's just noise.

@lkorth
Copy link
Member

lkorth commented Jan 9, 2015

@designatednerd did this answer your issue?

@designatednerd
Copy link
Author

@lkorth Yes, but I'd recommend leaving this open until the noise goes away so that anyone else encountering this issue is able to see what the problem is.

@imminent
Copy link

https://groups.google.com/forum/#!msg/adt-dev/rjTQ_STR3OE/-UcNQRISTKsJ has a solution for this. Just need to clean up the metadata on the PNGs.

@lkorth
Copy link
Member

lkorth commented Apr 29, 2015

Stripped assets coming soon to a release near you!

@imminent
Copy link

Thanks!

On Wed, Apr 29, 2015 at 10:03 AM Luke Korth notifications@github.com
wrote:

Stripped assets coming soon to a release near you!


Reply to this email directly or view it on GitHub
#16 (comment)
.

@designatednerd
Copy link
Author

👍

@lkorth lkorth closed this as completed in 2f96897 May 8, 2015
@lkorth
Copy link
Member

lkorth commented May 12, 2015

Just to note, there will still be some warnings generated because of the card form. I have made the commit to strip the metadata in the card form, however it won't take effect until the next version of the card form is released and Drop-in is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants