fix: controlled popover open on focus #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawid-klosowski-at-brainly
requested review from
krzotki,
Fasosnql and
radekwarisch
as code owners
stastur
approved these changes
Dec 17, 2024
Malinicz
approved these changes
Dec 17, 2024
matzimowski
approved these changes
Dec 17, 2024
krzotki
approved these changes
Dec 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added param to control the popover trigger on focus.
With "useFocus" on false, automatic visibility trigger on focus is disabled, but when focusing on element that triggers popover and press enter it will work as before.
Integration of controlled popover with the fix:
Screen.Recording.2024-12-16.at.17.54.13.mov
Before (focus changes to input of schoolbar but during first loading it triggers popover again):
Screen.Recording.2024-12-16.at.17.59.28.mov
On storybook all the states behave as before with 'useFocus' on default (unless focus + enter):
Screen.Recording.2024-12-17.at.08.57.00.mov