Fix overriding body styles when multiple Dialogs are open #2821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when multiple Dialogs were open, body styles got overridden before all modals were closed. As a solution, every modal will keep its initial body class and
top
value and will restore it upon cleanup.Before:
Screen.Recording.2024-12-04.at.11.07.03.mov
After:
Opening sibling modal and nested modal
Screen.Recording.2024-12-04.at.10.54.12.mov
Closing 2 modals at the same time (one is nested)
Screen.Recording.2024-12-04.at.11.03.05.mov
Style guide examples:
Screen.Recording.2024-12-04.at.11.59.17.mov