Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v17.0.1 #919

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Prepare v17.0.1 #919

merged 3 commits into from
Nov 8, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Nov 8, 2024

Proposed Changes

This PR prepares v17.0.1 release:

image

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 8, 2024
@barmac barmac requested a review from nikku November 8, 2024 13:00
@barmac
Copy link
Member Author

barmac commented Nov 8, 2024

The button position seems to depend on the scroll which makes the CI red but tests green on my machine.

Screen.Recording.2024-11-08.at.15.54.22.mov

The classes are not used anywhere, and parts are incorrect.
@barmac
Copy link
Member Author

barmac commented Nov 8, 2024

So the latest change of the test failed on CI because cellBounds.bottom is bigger than cellBounds.top + 10:

image

(https://github.com/bpmn-io/dmn-js/actions/runs/11744524874/job/32719837377?pr=919#step:5:3511)

And this makes sense after I had a look at the documentation. The coordinates returned by getBoundingClientRect are measured with the origin in the top-left corner, and growing to the bottom-left. So this means that rect.bottom >= rect.top for all cases.

Cf. https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect#return_value

This is required to make test pass both on CI and MacOS,
cf. #919
@barmac barmac merged commit ae5050f into develop Nov 8, 2024
8 checks passed
@barmac barmac deleted the prepare-17-0-1 branch November 8, 2024 15:30
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants