Add CodeQL to recognised languages #317
Conversation
edoardopirovano
force-pushed
the
add-codeql
branch
from
22c76e6
to
46d524b
Compare
|
Neat! I did not know Also a very high quality PR to boot! Looks perfect to me and thank you for including a link to the language spec which makes this much easier than having to search around for it. Approved. Should make the next version, although you can build from mainline if you need it faster. |
Thanks! We're already building from an internal fork of your last release with this patch (and also #295 which one of my colleagues wrote) applied, but it's good to get it included here so when you next do a release we can update our internal fork without having to reapply any patches. |
|
Ah neat. I really need to finish off the last few items in the queue. I hope to have it all done for Go 1.18 release so I can get the free performance improvements that usually brings. |
|
I am a child witnessing you from Morocco. I want to learn programming from you |
Greetings, I hope you are doing well. I'm one of the language maintainers for CodeQL, a language for querying codebases in order to find vulnerabilities (which, in fact, you are using here). This PR adds CodeQL to the set of languages that
sccwill recognise and count lines for. Our language specification can be found here if you'd like to double check that what I have done is a sensible representation of that.We have a slight vested interest in this since the CodeQL engine actually uses
sccunder the hood to do some line counting (in particular, if you go to the Security tab for a GitHub repository that is using CodeQL and you are an admin of, then click Code scanning alerts and the total number of lines under Lines scanned is coming fromscc). We've recently started looking into using CodeQL to analyse our own CodeQL code, so getting this PR in would allow us to get sensible line counts for our own code there.