Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace log4rs with tracing #160

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Replace log4rs with tracing #160

merged 4 commits into from
Jun 18, 2022

Conversation

mucinoab
Copy link
Contributor

Fixes #158

@boxdot
Copy link
Owner

boxdot commented Jun 17, 2022

Thank you!

@boxdot boxdot self-requested a review June 17, 2022 20:24
@mucinoab
Copy link
Contributor Author

I am not quite sure what to do about the conflicts... 😞

@boxdot
Copy link
Owner

boxdot commented Jun 17, 2022 •
edited
Loading

I am not quite sure what to do about the conflicts... 😞

You can just check out Cargo.lock from the master branch in your branch, and then run e.g. cargo check again. It will generate a new fitting Cargo.lock.

@boxdot
Copy link
Owner

boxdot commented Jun 18, 2022

@mucinoab I merged the master and resolved the conflicts. Also removed a dbg statement. Ready to merge!

@boxdot boxdot enabled auto-merge (squash) June 18, 2022 11:05
@boxdot boxdot merged commit 3f200fc into boxdot:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boxdot boxdot boxdot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace log4rs by tracing
2 participants
@mucinoab @boxdot