-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Next.js middleware #516
Conversation
@lancedikson @voronianski Can we get this merged please? We rely heavily on your package in multiple places and would really love for our browser parsing to be the same in the Next.js middleware. |
@connor-baer Thanks for the fix! I forked it and tested it and it looks like your solution needs to be applied on 4 more areas in the @voronianski You may want to request changes so that gets addressed before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @zeckdude! I think these code paths weren't reached in my testing, so the initial fix worked for my use case. Makes absolute sense to fix it everywhere though! |
Vielen Dank! |
I'm having the same problem, so when can this PR be merged. |
Hey folks, I had forked https://github.com/mkkhedawat/frowser from this project recently given the inactivity from maintainer here. Would love to have this included in PR there if that is of interest. |
Fixes #512.