Include the captured exception on invalid JSON #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that makes a lot of sense. No CLA needed (Bottle is MIT Licensed). I'll check this tomorrow and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this as an issue while handling the bottle 0.13 update from 0.12.
The behavior of JSON decoding failures has changed slightly vs 0.12, and while updating I was surprised to find that
error.exceptionwas unset, when a JSONDecodeError was caught.Setting the inner exception to the caught exception helps callers catch and re-emit JSON decoding errors with their own code (e.g., to meet error API standards for their application).
Please let me know if this PR is missing anything it needs to progress.
I'm happy to take extra steps (add new tests, sign a CLA, etc) as appropriate.