This repository has been archived by the owner on May 10, 2024. It is now read-only.
remove obsolete md5 import routine #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old md5 module was deprecated since Python 2.5, and we even didn't support that version already. The current implementation in boto/utils.py will not even work under Python 2.4 because of the name "md5" imported from md5 module was replaced by the md5 module in the following routine, which will cause errors.
|
This looks great, thanks! 👍 |
danielgtaylor
added a commit
that referenced
this pull request
Aug 1, 2014
Remove obsolete md5 import routine. Fixes #2468.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old md5 module was deprecated since Python 2.5, and we even didn't
support that version already. The current implementation in
boto/utils.py will not even work under Python 2.4 because of the name
"md5" imported from md5 module was replaced by the md5 module in the
following routine, which will cause errors.
This PR just replaced the routine with a simple import from
hashlib, which will work flawlessly in Python 2.5+ and 3.*.