This repository has been archived by the owner on May 10, 2024. It is now read-only.
Skip the ETag header check in responce while using SSE-C encrpytion of S3 #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Can't wait to use this |
|
+1 - this would make our lives much easier |
|
Does any one know how to accelerate the merge of this pull request? Any suggestion? Thanks! |
| raise provider.storage_data_error( | ||
| 'ETag from S3 did not match computed MD5. ' | ||
| '%s vs. %s' % (self.etag, self.md5)) | ||
| # If you use customer-provided encryption keys, the ETag value that Amazon S3 returns in the response will not be the MD5 of the object. |
There was a problem hiding this comment.
Line length (PEP8, should be 80 chars max)
|
Thanks for this pull request. It looks great so far, but would need to have at least a unit test added to cover this new functionality. If someone can add a test then I'll merge it in. 👍 |
…issue to align PEP8
|
@danielgtaylor I've added one test for this pull request and fixed the style issue. Would you please have a look and merge it if it is Ok. Thanks! |
|
Can any one give me the guidance to do anything else to have this pull request merged? Thanks! |
|
Thanks for adding the test! 👍 |
danielgtaylor
added a commit
that referenced
this pull request
Jul 22, 2014
Skip the ETag header check in responce while using SSE-C encrpytion of S3. Fixes #2368.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS S3 provides the new feature - server side encrpytion with customer keys. I can add three headers - "x-amz-server-side-encryption-customer-algorithm,x-amz-server-side-encryption-customer-key,x-amz-server-side-encryption-customer-key-MD5" to use the Key.set_contents_from_filename and upload the file. However, the ETag check in response stops the operation.
According to the AWS document, this header takes no effect while using the new SSE-C encryption. So this fix is to skip this check. "x-amz-server-side-encryption-customer-algorithm" is one header in the response, which I use to determine if it is SSE-C encryption.