This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add S3 SigV4 Presigning #2349
Merged
Add S3 SigV4 Presigning #2349
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielgtaylor
added a commit
that referenced
this pull request
Jun 27, 2014
Add S3 SigV4 Presigning. Fixes #2349.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with presigning when signature version 4 is used with S3. It also includes a minor fix for determining the signing region name for vhosted classic domains. Example output:
@jamesls, please review.