This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix "consistent" argument to boto.dynamodb2.table.Table.batch_get #2272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the argument
consistent
is ignored, and insteadFalse
is passed to helper functionself._batch_get
, effectively enforcing eventual consistency for all reads made viaboto.dynamodb2.table.Table.batch_get
.This fixes what could be a serious issue for callers expecting strongly consistent reads when setting
consistent=True
.