Adds TypeScript Types #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
reviewed
May 28, 2021
janmonschke
reviewed
May 28, 2021
Comment on lines
+9
to
+13
| interface AvatarComponent { | ||
| (props: AvatarProps, context?: any): React.ReactElement | null; | ||
| } | ||
|
|
||
| const Avatar: AvatarComponent |
There was a problem hiding this comment.
You could simplify this into:
Suggested change
| interface AvatarComponent { | |
| (props: AvatarProps, context?: any): React.ReactElement | null; | |
| } | |
| const Avatar: AvatarComponent | |
| const Avatar: React.FunctionComponent<AvatarProps>; |
That way it does not require the use of any 🎉
There was a problem hiding this comment.
FunctionComponent adds children to props, but this library does not use the children prop. I copied the above from the React.FunctionComponent type and omitted what was unnecessary.
|
Great idea! I came here to do the same and was happy to see your PR 🥳 |
Co-authored-by: Jan Monschke <janmonschke@fastmail.com>
|
Thank you @bozdoz, looks good to me 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey cool project! Just trying it out and noticed it didn't have any types. Seemed simple enough to add them, based on the types given in the README. ✌️