Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two helper methods to
ISAM2Result
which allows wrapper access to theerrorBefore
anderrorAfter
nonlinear errors of ISAM2.The helper methods are setup to leverage the boost optional capabilities, such that if
evaluateNonlinearError
isFalse
, they will returnnan
. This works great with the python wrapper i.e. the result is printed out asnan
.Example use case:
This method has proven super useful in helping to debug various setup issues in ISAM2 by evaluating the error.
Any feedback involving location of tests for these methods?