Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a bug or why not numlock? #245

Open
kivdev opened this issue Feb 23, 2019 · 7 comments
Open

Is this a bug or why not numlock? #245

kivdev opened this issue Feb 23, 2019 · 7 comments

Comments

@kivdev
Copy link

kivdev commented Feb 23, 2019

https://github.com/boppreh/keyboard/blob/master/keyboard/_canonical_names.py
39: 'numlock:': 'num lock',

glitchassassin added a commit that referenced this issue Feb 24, 2019
@glitchassassin
Copy link
Collaborator

Agree that looks like a bug. Fixed in master branch.

@BlivetWidget
Copy link

@glitchassassin Thank you for your continued work on this excellent package. Would it be possible for you to create a new release? Keyboard hasn't worked on Python 3.7 since release, and the already-committed fix to #186 was intended to fix that... almost a year ago.

Thanks in advance for having a look.

@kivdev
Copy link
Author

kivdev commented Mar 18, 2019

@glitchassassin Thank you for your continued work on this excellent package. Would it be possible for you to create a new release? Keyboard hasn't worked on Python 3.7 since release, and the already-committed fix to #186 was intended to fix that... almost a year ago.

Thanks in advance for having a look.

I just checked on version 3.7.2 x32. Works.

@boppreh
Copy link
Owner

boppreh commented Mar 18, 2019

Hi all

Sorry for not maintaining the package as I should, I have not been doing too well personally. I just released version 0.13.3 with the fixes mentioned. Once again thanks a lot for @glitchassassin for this amazing selfless work. I hope I'll be able to help again in the near future.

@BlivetWidget
Copy link

@kivdev some features did, some did not.

@glitchassassin and @boppreh thank you both for your hard work! New release working as expected.
It's great to have hotkeys available again. I'm sorry to hear about personal difficulties, boppreh, is there a way I can help? Perhaps a paypal address I can send you an appreciatory e-beer at the very least?

@boppreh
Copy link
Owner

boppreh commented Mar 18, 2019

@BlivetWidget thanks for your appreciation, and for the offer. Seeing people using these projects is rewarding enough for me.

@BlivetWidget
Copy link

@boppreh I definitely do, it's among the 11 core 3rd party modules I use regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants