Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_typed_strings allow_backspace doesn't work on OSX #149

Closed
peterxu30 opened this issue Mar 30, 2018 · 5 comments
Closed

get_typed_strings allow_backspace doesn't work on OSX #149

peterxu30 opened this issue Mar 30, 2018 · 5 comments
Labels
bug osx waiting-for-feedback

Comments

@peterxu30
Copy link
Contributor

peterxu30 commented Mar 30, 2018 •
edited
Loading

The OSX key for backspace is listed as delete when checking the event name. Modifying the get_typed_strings function to (event.name == 'backspace' or event.name == 'delete') in line 990 of __init__.py solves the issue but there may be a more elegant solution.
@boppreh
Copy link
Owner

boppreh commented Mar 30, 2018

Thanks for the bug report. This one is tricky because "delete" means a different key in Windows/Linux (erase next character, not previous). The correct "solution" (read hack) would be to set the backspace key name depending on the platform.

boppreh added a commit that referenced this issue Mar 30, 2018
@boppreh
Make get_typed_strings listen for 'delete' on OSX (#149)
a4d831b
@boppreh
Copy link
Owner

boppreh commented Mar 30, 2018

I think I've fixed it with a4d831b, but it's still hacky. But again, get_typed_strings is a entirely hacky.

Feedback appreciated.

@peterxu30
Copy link
Contributor Author

Looks good!

@boppreh
Copy link
Owner

boppreh commented Apr 3, 2018

Excellent. I will close the issue, but feel free to comment if you have any other findings, and I'll reopen it if needed.

Thank you for your report!

@boppreh boppreh closed this as completed Apr 3, 2018
@HJFG
Copy link

HJFG commented Apr 24, 2018

In lastest version still got this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug osx waiting-for-feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boppreh @peterxu30 @HJFG