Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't work on WindowsXP #132

Closed
Anniywell opened this issue Mar 2, 2018 · 2 comments
Closed

Don't work on WindowsXP #132

Anniywell opened this issue Mar 2, 2018 · 2 comments
Labels
bug windows

Comments

@Anniywell
Copy link

I use keyboard on XP, but it does not work.
I feel the problem is here：

keyboard_hook = SetWindowsHookEx(WH_KEYBOARD_LL, keyboard_callback, NULL, NULL)

then I replace it with:

keyboard_hook = SetWindowsHookEx(WH_KEYBOARD_LL, keyboard_callback, GetModuleHandleA(None), NULL)

It can work on XP，is there any problem with my changes?
@boppreh
Copy link
Owner

boppreh commented Mar 2, 2018

I don't want to get into the rabbit hole of supporting wildly out of date platforms, but if the change is as simple as that, that's OK for me. I'll first take a better look at the documentation for these functions to ensure it's not going to break anything.

boppreh added a commit that referenced this issue Mar 25, 2018
@boppreh
Use GetModuleHandle to fix WindowsXP bug #132
9289aeb
@boppreh
Copy link
Owner

boppreh commented Mar 26, 2018

v0.13.0 now contains this fix. Feel free to reopen the issue if you still experience problems.

Thank you for reporting the issue and the solution at the same time!

@boppreh boppreh closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boppreh @Anniywell