Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of deprecated header boost/detail/iterator.hpp #91

Merged
merged 1 commit into from
May 12, 2020
Merged

Remove use of deprecated header boost/detail/iterator.hpp #91

merged 1 commit into from
May 12, 2020

Conversation

Lastique
Copy link
Member

The header is deprecated in favor of <iterator>. It generates compiler warnings and will be removed in a future release.

Also, added a missing include for iterator_value trait.

@jefftrull
Copy link
Collaborator

Thanks for the PR @Lastique . Will this code work OK with C++03?

@Lastique
Copy link
Member Author

Yes, I see no reason why it shouldn't.

@jefftrull
Copy link
Collaborator

Thank you. Do we need <iterator> at all? I don't see us using any iterator traits from std. Should we remove the Boost traits entirely and use std::iterator_traits<Iterator>::value_type instead?

@Lastique
Copy link
Member Author

There is a call to std::advance down in the code.

@jefftrull
Copy link
Collaborator

Ah, OK. What do you think about replacing boost::iterators::iterator_value with std::iterator_traits<>::value_type and eliminating the Boost header entirely?

@Lastique
Copy link
Member Author

Sure, I can do that.

@Lastique
Remove use of deprecated header boost/detail/iterator.hpp.
9509a04 
The header is deprecated in favor of <iterator>. It generates compiler
warnings and will be removed in a future release.

Also, replaced iterator_value trait with iterator_traits.
@Lastique Lastique force-pushed the fix_deprecated_headers branch from a8d3815 to 9509a04 Compare May 11, 2020 20:57
@Lastique
Copy link
Member Author

Done.

hkaiser
hkaiser approved these changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jefftrull
Copy link
Collaborator

@Lastique Travis failed with a Clang issue related to Filesystem - it looks like you were the last to touch the associated file :) Would you be willing to look at the failure?

@Lastique
Copy link
Member Author

That failure is unrelated to this PR. Looks like struct stat has unexpected layout on Darwin, which makes Boost.Filesystem fail to compile. I'll take care of that in Boost.Filesystem.

@Lastique
Copy link
Member Author

You can restart the CI job, it should succeed now.

@jefftrull jefftrull merged commit 2970a40 into boostorg:develop May 12, 2020
@Lastique Lastique deleted the fix_deprecated_headers branch May 12, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lastique @jefftrull @hkaiser