Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BOOST_OVERRIDE to virtual functions in derived classes #89

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add BOOST_OVERRIDE to virtual functions in derived classes #89

merged 1 commit into from
Apr 14, 2020

Conversation

jefftrull
Copy link
Collaborator

If merged this will resolve #88

@jefftrull jefftrull requested a review from hkaiser April 13, 2020 22:51
hkaiser
hkaiser approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks!

@jefftrull jefftrull merged commit 2e8eeee into boostorg:develop Apr 14, 2020
@jefftrull jefftrull deleted the bugfix/suggest-override branch April 14, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCC suggest-override warnings
2 participants
@jefftrull @hkaiser