Instantiate lexers with std::string, not flex_string #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main programs of these samples use std::string to instantiate their context object, which propagates down to the type of the lexer. The manual instantiations use BOOST_WAVE_STRINGTYPE a.k.a flex_string and so do not satisfy the missing symbols, giving a link error.
|
I think this resolves TRAC 6588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two samples fail at the link stage looking for a different
new_lexer_gen<>::new_lexer()than we provide.AFAICT the type of the lexer is dependent on what string was used to construct the wave context object and that propagates down. Updating these files fixes the error.