backward-cpp: Make sure to properly link against bfd.a #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some distributions, libbfd is only available as static library. E.g. on OpenSuse Leap 42.2, there are these two files: libbfd.a libbfd-2.28-system.so backward-cpp, when attempting to link to bfd, will select the static library and fail b/c there are undefined references to symbols from libiberty/libz: ``` /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../lib64/libbfd.a(elflink.o): In function `elf_link_add_object_symbols': /home/abuild/rpmbuild/BUILD/binutils-2.26.1/build-dir/bfd/../../bfd/elflink.c:4733: undefined reference to `objalloc_free_block' /home/abuild/rpmbuild/BUILD/binutils-2.26.1/build-dir/bfd/../../bfd/elflink.c:5027: undefined reference to `_sch_istable' ... ``` After this patch we also link against the direct dependencies of libbfd.a, namely libiberty and libz Also see: KDAB/GammaRay#386
|
Bump? |
|
Sorry for the lag. Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some distributions, libbfd is only available as static library. E.g.
on OpenSuse Leap 42.2, there are these two files:
libbfd.a
libbfd-2.28-system.so
backward-cpp, when attempting to link to bfd, will select the static
library and fail b/c there are undefined references to symbols from
libiberty/libz:
After this patch we also link against the direct dependencies of libbfd.a, namely libiberty and libz
Also see: KDAB/GammaRay#386