Update workspace versions when running bolt add on an existing dependency in the project root #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency in the project root
lukebatchelor
approved these changes
Oct 2, 2019
| @@ -148,6 +148,10 @@ describe('utils/addDependenciesToPackages', () => { | |||
| let packages = await project.getPackages(); | |||
| let fooPkg = project.getPackageByName(packages, 'foo'); | |||
| let barPkg = project.getPackageByName(packages, 'bar'); | |||
| if (!fooPkg || !barPkg) { | |||
| // This check is required to satisfy flow | |||
| throw new Error('missing packages'); | |||
There was a problem hiding this comment.
Could we make this more descriptive? I know you should never see it anyway, but could we add that context to the message?
Edit: discussed, not really a massive issue.
|
Released in 0.24.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the
bolt addcommand in the last version to re-runyarn addwhen run from the project root to allow installing new versions of an existing dependency without needing to runbolt upgradewhich behaves differently (it recursively upgrades transitive deps).As part of this work, we forgot to also update the versions of the dependency being added in each workspace in the repo. Resulting in version mismatch errors on subsequent runs of bolt until workspace versions were manually updated.