Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update toml++ to v3.1.0 #69

Merged
merged 1 commit into from
May 13, 2022
Merged

update toml++ to v3.1.0 #69

merged 1 commit into from
May 13, 2022

Conversation

marzer
Copy link
Collaborator

@marzer marzer commented May 9, 2022 •
edited
Loading

also:

  • update benchmark script to handle parse failures
  • update benchmark data to better stress-test parsers
  • added PEP 680 awareness to the benchmark script (tomllib)
  • made the toml++ submodule shallow by default
  • minor perf tweaks

@marzer
Copy link
Collaborator Author

marzer commented May 9, 2022 •
edited
Loading

@pwwang Note that this PR replaces the benchmark data.toml with a much larger and more complex one that makes use of some TOML v1.0.0 features; you might need to update toml-bench to take this into account:

  • sdispater/tomlkit takes an eternity to get through 5000 iterations
  • uiri/toml fails to parse it at all (it doesn't understand heterogenous arrays)

@marzer marzer marked this pull request as draft May 9, 2022 11:48
@marzer
Copy link
Collaborator Author

marzer commented May 9, 2022 •
edited
Loading

Actually, don't merge this yet. Just realized there might be a way I can make the TOML => python bits faster.

@marzer
update toml++ to v3.1.0
882d6db 
also:
- updated benchmark script to handle parse failures
- updated benchmark data
- added PEP 680 awareness to the benchmark script (tomllib)
- made the toml++ submodule shallow by default
- minor perf tweaks
@marzer marzer marked this pull request as ready for review May 9, 2022 14:23
@marzer marzer changed the title update toml++ to 3.1.0 update toml++ to v3.1.0 May 9, 2022
@marzer
Copy link
Collaborator Author

marzer commented May 9, 2022

Well, no huge perf gains. Oh well. On the plus side, I was able to simplify some things using v3.1.0's for_each() ^_^

@bobfang1992
Copy link
Owner

Hi, thanks! feel free to merge it!

@marzer marzer merged commit e43711f into bobfang1992:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobfang1992 bobfang1992 bobfang1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marzer @bobfang1992