Maven integration test refactoring #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/it is the conventional location for maven-invoker-plugin integration tests. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
prebuild and postbuild are the conventional names for maven-invoker-plugin integration tests pre and post build scripts. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
We reduce the output of successful builds. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
This avoids the need to add dependencies to the maven-invoker-plugin. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
This avoids the need to define goals in maven-invoker-plugin plugin configuration. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
|
wow, nice effort here... |
I decided to learn how to properly do maven integration testing using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests for the Bnd maven plugins are refactored so that there are multiple integration tests per plugin instead of a single integration test having a reactor with multiple projects. The integration tests now use the normal maven conventions for directory and file names (e.g.
src/it,postbuild).This refactoring allows running individual tests rather than all the tests for a plugin. Using the
invoker.propertiesfiles allows for tests to having individual goals and debug log level. It also allows for an individual test to be started in debug mode and wait for a debugger to attach. It allows for all tests to execute even if one fails.The normal output from integration test execution is now minimal unless an error occurs in the test so the build output is much shorter.