Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstrings, code comments; run autopep8 #19

Merged
merged 7 commits into from
Apr 8, 2020
Merged

Add docstrings, code comments; run autopep8 #19

merged 7 commits into from
Apr 8, 2020

Conversation

duckworthd
Copy link
Contributor

This PR is a no-op on functionality. It includes docstrings, code comments, and reformats run_nerf.py and run_nerf_helpers.py with autopep8.

bmild
bmild reviewed Apr 8, 2020
View reviewed changes
Copy link
Owner

@bmild bmild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left edit suggestions on some of the comments.

run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf.py Outdated Show resolved Hide resolved
run_nerf_helpers.py Outdated Show resolved Hide resolved
run_nerf_helpers.py Outdated Show resolved Hide resolved
duckworthd
duckworthd commented Apr 8, 2020
View reviewed changes
Copy link
Contributor Author

@duckworthd duckworthd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks Ben!

duckworthd and others added 2 commits April 8, 2020 12:19
@duckworthd @bmild
Update run_nerf.py
806e394 
Co-Authored-By: bmild <bmild@cs.berkeley.edu>
@duckworthd @bmild
Apply suggestions from code review
c7f6253 
Co-Authored-By: bmild <bmild@cs.berkeley.edu>
tancik
tancik approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmild bmild merged commit d23b87b into bmild:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmild bmild bmild left review comments

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duckworthd @tancik @bmild