Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrtc: allow configuring timeouts (#3404) #3406

Merged
merged 2 commits into from
May 30, 2024
Merged

webrtc: allow configuring timeouts (#3404) #3406

merged 2 commits into from
May 30, 2024

Conversation

jwalton
Copy link
Contributor

@jwalton jwalton commented May 29, 2024

Allow configuration of WebRTC timeouts.

aler9
aler9 requested changes May 29, 2024
View reviewed changes
Copy link
Member

@aler9 aler9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this patch, take a look at the comment in the review

internal/core/core.go Show resolved Hide resolved
@aler9 aler9 merged commit 1c2f95f into bluenviron:main May 30, 2024
6 checks passed
@aler9
Copy link
Member

aler9 commented May 30, 2024

merged, thanks!

@aler9 aler9 mentioned this pull request May 30, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aler9 aler9 aler9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwalton @aler9