Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WHEP Source auto reconnection #3062

Closed
1 of 13 tasks
tiz47 opened this issue Feb 23, 2024 · 2 comments · Fixed by #3110
Closed
1 of 13 tasks

WHEP Source auto reconnection #3062

tiz47 opened this issue Feb 23, 2024 · 2 comments · Fixed by #3110
Labels
bug Something isn't working webrtc

Comments

@tiz47
Copy link

tiz47 commented Feb 23, 2024

Which version are you using?

v1.5.1

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

proxied whep source stop working after stopping the whep stream. and it doesn't start again until mediamtx is restarted

Describe how to replicate the issue

  1. create a path (whep-test), with whep source
  2. read with vlc with rtsp
  3. stop the whep stream
  4. start the whep stream again
  5. vlc is unable to read the stream via rtsp
  6. deleting and recreating the path doesn't fix it, the path remains broken

trying with rtmp source instead of whep works without problems.

Did you attach the server logs?

yes

2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20016] opened
2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20016] closed: no one is publishing to path 'whep-test'
2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20017] opened
2024/02/23 15:52:50 INF [RTSP] [session f62d4d7c] created by 10.0.0.2:20017
2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20017] closed: invalid URL ((null))
2024/02/23 15:52:50 INF [RTSP] [session f62d4d7c] destroyed: not in use
2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20018] opened
2024/02/23 15:52:50 INF [RTSP] [conn 10.0.0.2:20018] closed: EOF

Did you attach a network dump?

no
@RouquinBlanc
Copy link
Contributor

Getting the same issue in a setup where 2 mediamtx instances are connected via WHEP over the internet:

CLIENTS --RTSP/local--> MEDIAMTX --WHEP/internet--> MEDIAMTX --> source (whatever, but mostly RTSP)

clients fail to get video via RTSP after a while, which we have associated mostly with a restart of the distant instance, but potentially also a temporary loss of connectivity without restart.

@RouquinBlanc RouquinBlanc mentioned this issue Mar 5, 2024
Closed
14 tasks
@aler9 aler9 linked a pull request Mar 6, 2024 that will close this issue
webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) #3110
Merged
@aler9 aler9 added bug Something isn't working webrtc labels Mar 6, 2024
aler9 added a commit that referenced this issue Mar 6, 2024
@RouquinBlanc @aler9
webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) (#3110)
732bf56 
Co-authored-by: Jonathan Martin <jonathan.martin@marss.com>
Co-authored-by: aler9 <46489434+aler9@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@BrewTestBot BrewTestBot mentioned this issue Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) RouquinBlanc/mediamtx
3 participants
@RouquinBlanc @tiz47 @aler9