Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DURATION param for runOnRecordSegmentComplete hook #2983

Closed
neutralvibes opened this issue Feb 3, 2024 · 4 comments · Fixed by #3456
Closed

DURATION param for runOnRecordSegmentComplete hook #2983

neutralvibes opened this issue Feb 3, 2024 · 4 comments · Fixed by #3456
Labels
enhancement New feature or request record playback

Comments

@neutralvibes
Copy link

neutralvibes commented Feb 3, 2024 •
edited
Loading

Describe the feature

Description

Duration parameter for runOnRecordSegmentComplete hook

Wondering if it is possible to provide some meta data params or at least segment duration passed to the runOnRecordSegmentComplete hook.

How would this help? Calling ffprobe to discern it, adds to processing time and, supplying it via the hook would make it relatively trivial to store the info in either a database or meta data file via a routine called by the hook.

Thanks for considering.
@t3therdev
Copy link

@aler9 anyway to bump this? what are your thoughts? it would definitely be helpful for us as well as we want to put this into a db on our side as @neutralvibes suggests.

@t3therdev
Copy link

hi @aler9 just wanted to see if we can get this into the next release.

@aler9 aler9 added enhancement New feature or request record playback labels May 5, 2024
@moenodedev
Copy link

moenodedev commented May 15, 2024 •
edited
Loading

This would also be useful when maintaining a list of segments for HLS playback served by nginx. We need the duration for each segment in the m3u8 playlist.

@moenodedev moenodedev mentioned this issue Jun 9, 2024
Closed
@aler9 aler9 mentioned this issue Jun 11, 2024
Merged
aler9 added a commit that referenced this issue Jun 11, 2024
@aler9
expose MTX_SEGMENT_DURATION to runOnRecordSegmentComplete (#3440) (#2983
3eabe6a 
) (#3456)

* improve tests

* add duration to OnSegmentComplete

* expose MTX_SEGMENT_DURATION to runOnRecordSegmentComplete

* add tests
@github-actions GitHub Actions
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request record playback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expose MTX_SEGMENT_DURATION to runOnRecordSegmentComplete (#3440) (#2983) bluenviron/mediamtx
4 participants
@neutralvibes @t3therdev @aler9 @moenodedev