Fix mjpeg type 0 check #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type 0 corresponds to YUV 4:2:2. Since this header is passed directly to the JPEG header, no additional changes are necessary for support. See the type field here: https://datatracker.ietf.org/doc/html/rfc2435#section-4.1 I have a stream producing YUV 4:2:2 mjpeg over RTSP and have confirmed manually that piping this through ffmpeg as a jpeg decoder results in correct decoding.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 81.26% 81.31% +0.05%
==========================================
Files 115 115
Lines 11622 11622
==========================================
+ Hits 9445 9451 +6
+ Misses 1769 1765 -4
+ Partials 408 406 -2 ☔ View full report in Codecov by Sentry. |
|
Hello, i checked in other implementations and i found out that types 0-63 can be enabled without further changes, so i expanded the check in both the decoder and encoder. This has been merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type 0 corresponds to YUV 4:2:2. Since this header is passed directly to the JPEG header, no additional changes are necessary for support. See the type field here: https://datatracker.ietf.org/doc/html/rfc2435#section-4.1
I have a stream producing YUV 4:2:2 mjpeg over RTSP and have confirmed manually that piping this through ffmpeg as a jpeg decoder results in correct decoding.