Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bloom wallet #2209

Merged
merged 18 commits into from
Jun 24, 2024
Merged

feat: add bloom wallet #2209

merged 18 commits into from
Jun 24, 2024

Conversation

MarkNerdi
Copy link
Contributor

@MarkNerdi MarkNerdi commented May 29, 2024 •
edited
Loading

Description

This PR add Bloom wallet to the list of supported wallets

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@MarkNerdi MarkNerdi marked this pull request as draft May 29, 2024 08:18
@MarkNerdi MarkNerdi mentioned this pull request May 29, 2024
Closed
@MarkNerdi MarkNerdi marked this pull request as ready for review May 30, 2024 14:16
Adamj1232
Adamj1232 reviewed Jun 11, 2024
View reviewed changes
packages/bloom/package.json Outdated
@@ -0,0 +1,77 @@
{
"name": "@web3-onboard/bloom",
"version": "2.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "2.1.2",
"version": "2.0.0-alpha.1",

@Adamj1232
Copy link
Member

Hi @MarkNerdi it looks like the build is failing within the PR status checks - can you have a look when you get a moment?

@MarkNerdi
Copy link
Contributor Author

@Adamj1232
Updated the code, can you run the workflow again pls? 🙏

@socket-security Socket Security
Copy link

socket-security bot commented Jun 13, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Adamj1232
Copy link
Member

@MarkNerdi local testing and build went well. I formatted the files and added the bloom module to the internal demo - packages/demo/package.json where it wasnt added. Was bloom wallet functionality tested using the internal demo on your end?

@MarkNerdi
Copy link
Contributor Author

@Adamj1232
Yes i tested it locally, for that i had to remove @web3onboad/bloom from the package.json, as that isnt published yet

@Adamj1232
Copy link
Member

@MarkNerdi code is looking good! When testing locally I am getting the following error:
Screenshot 2024-06-14 at 15 37 04

@MarkNerdi
Copy link
Contributor Author

@Adamj1232 This error occurs when you dont have bloom installed on you machine. Do you have an example in your project where a wallet prompts the user to download it? i could add that

@Adamj1232
Copy link
Member

@Adamj1232 This error occurs when you dont have bloom installed on you machine. Do you have an example in your project where a wallet prompts the user to download it? i could add that

@MarkNerdi ah gotcha, yeah we would def want to display a download message so users can add Bloom if they want - here is an example to display that message formatted using a helper function -

web3-onboard/packages/okx/src/index.ts

Line 35 in eb205fb

throw new Error(createDownloadMessage('OKX Wallet', downloadUrl))

@MarkNerdi
Copy link
Contributor Author

@Adamj1232
Sadly there is no consistent way to determine if an application is installed via the browser. The code in the newest PR checks if updating location.href to a specified protocl throws an error or not, which happens on Windows (and Mac) i think.

Adamj1232
Adamj1232 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing to W3O!

@Adamj1232 Adamj1232 merged commit 3f67ce2 into blocknative:develop Jun 24, 2024
3 checks passed
This was referenced Aug 14, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adamj1232 Adamj1232 Adamj1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkNerdi @Adamj1232